Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wireguard guide #591

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

AlexanderLieret
Copy link
Contributor

Removed the server config line "SaveConfig = true". This one does only
appear in the add client section.

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Adding the the config line SaveConfig=true enables WireGuard to save the configuration of an interface on exit.
The problem is that if you are following the guide, restarting WireGuard overwrites your config changes.

Another point is that this line only exists in the guide for adding a client and not for setting up the server.

According to some forum and reddit threads this is a problem.

How does this PR accomplish the above?:
Remove the offending line

What documentation changes (if any) are needed to support this PR?:
None of which I know

Removed the server config line "SaveConfig = true". This one does only
appear in the add client section.
@netlify
Copy link

netlify bot commented Nov 2, 2021

✔️ Deploy Preview for pihole-docs ready!

🔨 Explore the source changes: 92ab23c

🔍 Inspect the deploy log: https://app.netlify.com/sites/pihole-docs/deploys/618185e227ddbe0008f8414e

😎 Browse the preview: https://deploy-preview-591--pihole-docs.netlify.app/guides/vpn/wireguard/client

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this already here:
#467

The PR was closed due to inactivity and we forgot to delete the line.

@yubiuser yubiuser added the PR: Approved Open Pull Request, Approved by required number of reviewers label Nov 2, 2021
@DL6ER DL6ER merged commit a62e5a9 into pi-hole:master Nov 2, 2021
@pralor-bot
Copy link
Collaborator

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pihole-unbound-wireguard-dns-not-working/54233/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approved Open Pull Request, Approved by required number of reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants